<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25516">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25516#inline-144265">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">void</span> <span class="bright"></span><span class="n"><span class="bright">TagLibExtractor</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">readGenericProperties</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">PropertyMap</span> <span style="color: #aa2211">&</span><span class="n">savedProperties</span><span class="p">,</span> <span class="n">ExtractionResult</span><span style="color: #aa2211">*</span> <span class="n">result</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">readGenericProperties</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">PropertyMap</span> <span style="color: #aa2211">&</span><span class="n">savedProperties</span><span class="p">,</span> <span class="n">ExtractionResult</span><span style="color: #aa2211">*</span> <span class="n">result</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This puts <tt style="background: #ebebeb; font-size: 13px;">readGenericProperties(...)</tt> with external linkage in the global namespace.</p>

<p style="padding: 0; margin: 8px;">Put the private helpers in an anonymous namespace (and also include <tt style="background: #ebebeb; font-size: 13px;">extractAudioProperties(...)</tt> in it).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25516">https://phabricator.kde.org/D25516</a></div></div><br /><div><strong>To: </strong>astippich, Baloo, bruns, ngraham, mgallien<br /><strong>Cc: </strong>kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>