<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25117">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25117#565877" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25117#565877</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately<br />
 (genericsig_handler in slavebase.cpp).</p></div>
</blockquote>

<p>I didn't realize there was a timeout somewhere.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Hmm, the Windows code is probably a no-op then, there's no signal handler there to call setKillFlags(), so no opportunity to cleanup before dying.<br />
 Some research indicates that we'd have to use <tt style="background: #ebebeb; font-size: 13px;">SetConsoleCtrlHandler</tt> on Windows for similar behaviour. <br />
 <a href="https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap" class="remarkup-link" target="_blank" rel="noreferrer">https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap</a><br />
 <a href="https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/" class="remarkup-link" target="_blank" rel="noreferrer">https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/</a></p></blockquote>

<p>I did not realize that.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>OK so at least it seems feasible, so I won't object to the commit even if it doesn't implement it on Windows.</p></blockquote>

<p>This would be a regression in Windows, because of the code removal in <tt style="background: #ebebeb; font-size: 13px;">filecopyjob.cpp</tt>.<br />
I need to implement signal handling for windows starting at <tt style="background: #ebebeb; font-size: 13px;">KIOPrivate::sendTerminateSignal</tt> in <tt style="background: #ebebeb; font-size: 13px;">kioglobal_p_win.cpp</tt>. currently it simply kills directly the process. and use <tt style="background: #ebebeb; font-size: 13px;">SetConsoleCtrlHandler</tt> as you suggested to fix this.<br />
Or add a <tt style="background: #ebebeb; font-size: 13px;">#ifdef Q_OS_WIN</tt> block in filecopyjob.cpp.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25117">https://phabricator.kde.org/D25117</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure, ngraham, apol<br /><strong>Cc: </strong>apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>