<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25117">View Revision</a></tr></table><br /><div><div><p>Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately<br />
(genericsig_handler in slavebase.cpp).</p>
<p>Hmm, the Windows code is probably a no-op then, there's no signal handler there to call setKillFlags(), so no opportunity to cleanup before dying.<br />
Some research indicates that we'd have to use <tt style="background: #ebebeb; font-size: 13px;">SetConsoleCtrlHandler</tt> on Windows for similar behaviour. <br />
<a href="https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap" class="remarkup-link" target="_blank" rel="noreferrer">https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap</a><br />
<a href="https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/" class="remarkup-link" target="_blank" rel="noreferrer">https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/</a></p>
<p>OK so at least it seems feasible, so I won't object to the commit even if it doesn't implement it on Windows.<br />
-1 just for the missing QVERIFY.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25117#inline-143788">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:2171</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">spyResult</span><span class="p">.</span><span class="n">wait</span><span class="p">(</span><span style="color: #601200">500</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">exists</span><span class="p">(</span><span class="n">destToCheck</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Always use QVERIFY() around spy.wait().<br />
Well, I'm assuming we actually expect the signal to be emitted :-)<br />
I would also remove the 500 then, the default value will be fine.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25117">https://phabricator.kde.org/D25117</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure, ngraham, apol<br /><strong>Cc: </strong>apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>