<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: mart, davidedmundson, broulik.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25434">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>KDeclarative::setupBindings() is deprecated, replaced calls with its<br />
implementation (setupContext + static setupEngine call), but see comment<br />
about whether we can be sure this is done only once per engine, as<br />
requested by the setupEngine API. It's 100% equivalent to the old code<br />
though, can't be worse.</p>
<p>KPackage::contentsHash is deprecated, replaced call with implementation.</p>
<p>Depends on <a href="https://phabricator.kde.org/D25433" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25433</a> for the KActionCollection::changed signal.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25434">https://phabricator.kde.org/D25434</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
src/declarativeimports/core/corebindingsplugin.cpp<br />
src/plasma/package.cpp<br />
src/plasmaquick/configview.cpp<br />
src/plasmaquick/view.cpp<br />
src/scriptengines/qml/plasmoid/containmentinterface.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, mart, davidedmundson, broulik<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>