<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: kossebau, mart, davidedmundson.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25433">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>removed() is deprecated since 5.0 because the code has to downcast a partially<br />
destroyed QObject back to a QAction (from the slot connected to<br />
destroyed()). This is very dangerous, calling QAction methods will just<br />
crash.</p>
<p>plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp<br />
is using that removed() signal, but doesn't care about the argument,<br />
it's connecting both inserted() and removed() to a generic changed<br />
signal used to notify QML.</p>
<p>For this use case, all we need in KActionCollection is a changed() signal<br />
with no argument, emitted for both insertion and removal.</p>
<p>This makes me wonder if inserted() still is useful at all, but well, it<br />
doesn't hurt to keep it.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds, new test method passes</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25433">https://phabricator.kde.org/D25433</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kactioncollectiontest.cpp<br />
autotests/kactioncollectiontest.h<br />
src/kactioncollection.cpp<br />
src/kactioncollection.h</div></div></div><br /><div><strong>To: </strong>dfaure, kossebau, mart, davidedmundson<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>