<table><tr><td style="">davidedmundson marked 3 inline comments as done.<br />davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25326">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25326#inline-142990">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sortfiltermodel.cpp:84</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can we also just have it send <tt style="background: #ebebeb; font-size: 13px;">source_row</tt> and <tt style="background: #ebebeb; font-size: 13px;">source_parent</tt> since we have proper <tt style="background: #ebebeb; font-size: 13px;">QModelIndex</tt> handling now?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We could.</p>
<p style="padding: 0; margin: 8px;">Though means everyone doing a lookup immediately, handling columns and roles properly.</p>
<p style="padding: 0; margin: 8px;">More powerful, but slightly more complex for the user</p>
<p style="padding: 0; margin: 8px;">There's also the option of having two proxies with different behaviours?</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/mart/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mart</a> thoughts?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25326#inline-142984">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sortfiltermodel.h:43</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can this be a <tt style="background: #ebebeb; font-size: 13px;">QRegularExpression</tt>?<br />
I would assume a JS <tt style="background: #ebebeb; font-size: 13px;">RegExp</tt> object (or regexp literal <tt style="background: #ebebeb; font-size: 13px;">/syntax/</tt>) was supported (didn't test)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's not listed in <a href="https://doc.qt.io/qt-5/qtqml-cppintegration-data.html" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qtqml-cppintegration-data.html</a></p>
<p style="padding: 0; margin: 8px;">We need to test</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25326#inline-142978">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sortfiltermodel.h:63</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Or potentially we could just kill our handling of it?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did some investigation we have our handling just to emit a signal when the property changes!</p>
<p style="padding: 0; margin: 8px;">Another good thing to try to upstream.</p>
<p style="padding: 0; margin: 8px;">Keeping the same name allows us to subtly drop the API in the future and keep clients working.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25326#inline-142985">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sortfiltermodel.h:78</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Is this needed?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think so. We've implemented it in a lot of plasma models, presumably for some reason.</p>
<p style="padding: 0; margin: 8px;">Would be a good thing to try and upstream though.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25326#inline-142989">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sortfiltermodel.h:138</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Does this need a <tt style="background: #ebebeb; font-size: 13px;">d</tt> pointer or is it just for use in QML? Perhaps rename the header to <tt style="background: #ebebeb; font-size: 13px;">_p.h</tt> then?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't see why we would need a d pointer. We may as well self an allocation.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Perhaps rename the header to _p.h then?</p></blockquote>
<p style="padding: 0; margin: 8px;">We haven't done that universally in all frameworks, but sure I could.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R275 KItemModels</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25326">https://phabricator.kde.org/D25326</a></div></div><br /><div><strong>To: </strong>davidedmundson<br /><strong>Cc: </strong>broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>