<table><tr><td style="">cullmann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24568">View Revision</a></tr></table><br /><div><div><p>Btw., I just tried e.g.</p>

<p><a href="https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format" class="remarkup-link" target="_blank" rel="noreferrer">https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format</a></p>

<p>that one has exactly the same issues as our file and re-flows stuff into single lines (even lambdas).</p>

<p>The only thing that often hinders that is the column limit of 100 there.</p>

<p>That on the other side make as lot of code lot harder to read, too, like:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">-    cc()->unregisterCompletionModel(KTextEditor::EditorPrivate::self()->wordCompletionModel()); // would add additional items, we don't want that in tests
+    cc()->unregisterCompletionModel(KTextEditor::EditorPrivate::self()
+                                            ->wordCompletionModel()); // would add additional items,
+                                                                      // we don't want that in tests

-    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)->setBackground(searchColor);
-    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)->setForeground(foregroundColor);
-    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)->setBackground(searchColor);
-    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)->setForeground(foregroundColor);
+    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)
+            ->setBackground(searchColor);
+    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)
+            ->setForeground(foregroundColor);
+    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)
+            ->setBackground(searchColor);
+    highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)
+            ->setForeground(foregroundColor);</pre></div>

<p>(and that is just one of .... places in KTextEditor that look like that afterwards).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24568">https://phabricator.kde.org/D24568</a></div></div><br /><div><strong>To: </strong>cullmann, Frameworks, dfaure, broulik, davidedmundson<br /><strong>Cc: </strong>zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>