<table><tr><td style="">ahiemstra marked an inline comment as done.<br />ahiemstra added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25311">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>We should probably have a unit test, even if it just covers the basic case.</p></blockquote>
<p>Done.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>This currently assumes the source model's columns are static. At a minimum that needs a comment.</p></blockquote>
<p>Oops. That was not the intention. Fixed.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I'm wondering if this is technically a proxy model, or rather a QAbstractListModel? Its content is not representing cells in the source model after all, which mapTo/FromSource assumes I think.</p></blockquote>
<p>Yeah I'm not entirely sure. If it was possible I would probably have based this on QTransposeProxyModel, but that is Qt 5.13+ stuff.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>It works in the example as you implement the entire QAIM interface needed for it, so the mapping functions are probably not even called, until the source model changes, or you add a selection model on top.</p></blockquote>
<p>Most of what I needed I needed to implement because QAbstractProxyModel does not reimplement them.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R275 KItemModels</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25311">https://phabricator.kde.org/D25311</a></div></div><br /><div><strong>To: </strong>ahiemstra<br /><strong>Cc: </strong>vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>