<table><tr><td style="">ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24980">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24980#inline-142302">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobuidelegate.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                            <span class="n">sslMetaData</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"ssl_cipher_bits"</span><span class="p">)).</span><span class="n">toInt</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                            <span class="n">KSslInfoDialog</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">e</span>rrorsFromString</span><span class="p">(</span><span class="n">sslMetaData</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"ssl_cert_errors"</span><span class="p">))));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span class="n">KSslInfoDialog</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">certificateE</span>rrorsFromString</span><span class="p">(</span><span class="n">sslMetaData</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"ssl_cert_errors"</span><span class="p">))));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">kid</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nitpick, wouldn't QLatin1String be better here?</p>

<p style="padding: 0; margin: 8px;">c.f. Marc Mutz's talk about QStringLiteral and QLatin1String: <a href="https://youtu.be/Ov7s0GgBbOQ?t=2806" class="remarkup-link" target="_blank" rel="noreferrer">https://youtu.be/Ov7s0GgBbOQ?t=2806</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24980#inline-142297">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksslinfodialog.cpp:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QSslError</span><span style="color: #aa2211">::</span><span class="n">SslError</span><span style="color: #aa2211">>></span> <span class="n">KSslInfoDialog</span><span style="color: #aa2211">::</span><span class="n">certificateErrorsFromString</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">errorsString</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nitpick, shouldn't there be a "// static" comment like the other method?</p>

<p style="padding: 0; margin: 8px;">Wouldn't a QVector be better here (QVector<QList<QSslError::SslError>>)? that is IIUC what the QList docs and [1] are saying.</p>

<p style="padding: 0; margin: 8px;">[1]<a href="https://marcmutz.wordpress.com/effective-qt/containers/" class="remarkup-link" target="_blank" rel="noreferrer">https://marcmutz.wordpress.com/effective-qt/containers/</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>next</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24980">https://phabricator.kde.org/D24980</a></div></div><br /><div><strong>To: </strong>vkrause, nicolasfella<br /><strong>Cc: </strong>ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>