<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25123">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25123#558353" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25123#558353</a>, <a href="https://phabricator.kde.org/p/mglb/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mglb</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice though.</p></div>
</blockquote>
<p>I agree, the modified <tt style="background: #ebebeb; font-size: 13px;">A</tt> didn't turn out that well.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Note that size is perceived differently on different shapes - compare e.g. square and circle - with the same logical sizes, circle looks smaller (Breeze has this problem).<br />
The icon C is 48px wide (44px when counting only the screen), so 36px (38px with "handle" on the bottom) height makes its sizes visually similar to 40x40px square icons.</p>
<p>The same applies for alignment (see e.g. plasmadiscover.svg), but that shouldn't be a problem here.</p></blockquote>
<p>I'm aware of that. I know Material Design uses different sizes for circles, squares and rectangles for that reason. Unfortunately, switching to that system means we would need to change many icons. I believe the reason why we use the system we use is because of horizontal text alignment, but I think that matters more for monochrome icons than color icons. On the other hand, nothing actually lines up with text in a way that stands out as lining up particularly well whether you choose 10, 11 or 12pt Noto Sans.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25123">https://phabricator.kde.org/D25123</a></div></div><br /><div><strong>To: </strong>mglb, VDG, Yakuake, hein<br /><strong>Cc: </strong>ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns<br /></div>