<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25039">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25039#557004" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25039#557004</a>, <a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Not using references is not a big problem with QString nor QUrl since they are reference counting objects, say if you don't change their content they are immutable, so</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QString s = other; // it's fine
void func(QString s)
{
const QString o = s; // use o instead of s is also fine, using plain s is fine too, if you don't touch mutability
...
}</pre></div></div>
</blockquote>
<p>Using cont &, you still save some reference counting overhead and allow the compiler to make potential better optimization.<br />
In your example you'd also save the boilerplate needed just to have a variable const.<br />
This also makes API clearer about what to expect.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25039#inline-141559">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ftp.cpp:1378</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This here makes the code fragile and more confusing. What is the difference between <tt style="background: #ebebeb; font-size: 13px;">filename</tt> & <tt style="background: #ebebeb; font-size: 13px;">search</tt>? Why is <tt style="background: #ebebeb; font-size: 13px;">filename</tt> not const? Can it ever change? Would that be fine for <tt style="background: #ebebeb; font-size: 13px;">search</tt> to change as well?<br />
So while seemingly a correct optimization, as <tt style="background: #ebebeb; font-size: 13px;">filename</tt> seems not passed to any method modifying it, the resulting code is very strange to a human reader, the intent behind to have <tt style="background: #ebebeb; font-size: 13px;">search</tt> being a const reference to <tt style="background: #ebebeb; font-size: 13px;">filename</tt> seems mysterious.</p>
<p style="padding: 0; margin: 8px;">Without having understood the code, I would simply also make <tt style="background: #ebebeb; font-size: 13px;">filename</tt> a const variable, and add a hint why search is a const reference only (hinting this is for optimization).<br />
Though actually <tt style="background: #ebebeb; font-size: 13px;">search</tt> could be possibly be removed and checked what the purpose of the asserts have been and merge this with the code upfront. But outside of scope here, so leaving just a TODO for the next person should be fine. One can still be the next person oneself :)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I believe search can be removed in fact, fileName can be used interchangeably.<br />
That's the const beauty it makes this kind of issue visisble.<br />
But this patch is about fixing atomic warnings, not fixing code around those warnings.<br />
This can be fixed in a subsequent diff, thanks for pointing it out.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25039">https://phabricator.kde.org/D25039</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure<br /><strong>Cc: </strong>anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>