<table><tr><td style="">ahiemstra added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25067">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25067#inline-141489">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ngraham</span> wrote in <span style="color: #4b4d51; font-weight: bold;">EntryDetails.qml:95</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I don't think this works, since it's not inside another layout. Instead maybe <tt style="background: #ebebeb; font-size: 13px;">anchors.fill: parent</tt> would work better?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It does not. I am also unsure whether <tt style="background: #ebebeb; font-size: 13px;">anchors.fill</tt> will work, since the titleDelegate is instantiated by a loader and its sizing behaviour is somewhat fuzzy. The only option that is guaranteed to work is setting a proper implicitWidth for the delegate. I actually spent some time trying to get balanced auto sizing behaviour working for titles when doing the ActionToolBar work, but in the end gave up because things get really tricky when you have two items that resize based on the size of the other item.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25067">https://phabricator.kde.org/D25067</a></div></div><br /><div><strong>To: </strong>leinir, ngraham, KNewStuff, Frameworks, Plasma<br /><strong>Cc: </strong>ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>