<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25010">View Revision</a></tr></table><br /><div><div><p>Now that is a quick turn-around, +1 for doing the work :)</p>
<p>No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with an API police hat on.</p>
<p>Would be also good to have some patches which make use of the new API, so one could better judge the usefulness.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141241">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enum</span> <span class="n">Detail</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/// Filename, access, type, size, linkdest</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there other KIO API which has similar enums, where some consistency would be good to have?</p>
<p style="padding: 0; margin: 8px;">On a first look, the names seems very short & generic to me, having some other name element might avoid semantic collisions perhaps. No idea yet, not looked further.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141242">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enum</span> <span class="n">Detail</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/// Filename, access, type, size, linkdest</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add <span class="phabricator-remarkup-mention-unknown">@since</span> comment</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141232">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * Selects the level of @p details we want.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">setDetails</span><span class="p">(</span><span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Details</span> <span class="n">details</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add <span class="phabricator-remarkup-mention-unknown">@since</span></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141233">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">void</span> <span style="color: #004012">setDetails</span><span class="p">(</span><span style="color: #aa4000">short</span> <span style="color: #aa4000">int</span> <span class="n">details</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not deprecated now?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141235">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:174</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">constexpr</span> <span style="color: #aa4000">static</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Details</span> <span class="n">DefaultDetails</span> <span style="color: #aa2211">=</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Detail</span><span style="color: #aa2211">::</span><span class="n">Basic</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Detail</span><span style="color: #aa2211">::</span><span class="n">User</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Detail</span><span style="color: #aa2211">::</span><span class="n">Time</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Detail</span><span style="color: #aa2211">::</span><span class="n">Acl</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Detail</span><span style="color: #aa2211">::</span><span class="n">ResolveSymlink</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does KIO::DefaultDetails make sense beyond stat in the KIO namespace? How does it match other similar flags?<br />
Perhaps should be more bound to "stat" by the name.<br />
Please also add documentation, incl. "<span class="phabricator-remarkup-mention-unknown">@since</span>"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141236">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @return the job handling the operation.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KIOCORE_EXPORT</span> <span class="n">StatJob</span> <span style="color: #aa2211">*</span><span style="color: #004012">stat</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #aa2211">&</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatSide</span> <span class="n">side</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add <span class="phabricator-remarkup-mention-unknown">@since</span></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141238">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:209</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">Details</span> <span class="n">details</span><span class="p">,</span> <span class="n">JobFlags</span> <span class="n">flags</span> <span style="color: #aa2211">=</span> <span class="n">DefaultFlags</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/**</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Find all details for one file or directory.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please wrap the deprecated API call (incl. API dox comment) with visibilty controlling #if/#endif., so here</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64)</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141237">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:234</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * @param flags Can be HideProgressInfo here</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * @return the job handling the operation.</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add "<span class="phabricator-remarkup-mention-unknown">@deprecated</span> Since 5.64. Use KIO::stat(const QUrl &, KIO::StatJob::StatSide, StatJob::Details int, JobFlags)"</p>
<p style="padding: 0; margin: 8px;">For all the recommended details to add when deprecating API (also with the new deprecation macros), please see<br />
<a href="https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141239">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">short</span> <span style="color: #aa4000">int</span> <span class="n">details</span><span class="p">,</span> <span class="n">JobFlags</span> <span class="n">flags</span> <span style="color: #aa2211">=</span> <span class="n">DefaultFlags</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#if KIOCORE_ENABLE_DEPRECATED_SINCE(4, 0)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">#endif</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25010">https://phabricator.kde.org/D25010</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure, kossebau<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>