<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25010">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141259">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobremotetest.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Job</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">DestinationSide</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Job</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">DestinationSide</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">StatJob</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Basic</span></span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">setUiDelegate</span><span class="p">(</span><span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As reader of this code here alone, I wonder what KIO::StatJob::Basic means. To understand what this code does, I would first have to look at the API dox, not good.<br />
So possibly Basic should get a different name, at least contain "Detail" term perhaps. "Basic" also needs context to have semantics, I could e.g. not tell instantly what basic details are. So perhaps needs to be more expliciti here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141260">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">dest</span> <span style="color: #aa2211">=</span> <span class="n">m_asMethod</span> <span style="color: #aa2211">?</span> <span class="n">m_dest</span><span class="p">.</span><span class="n">adjusted</span><span class="p">(</span><span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">RemoveFilename</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">m_dest</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Job</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat</span><span class="p">(</span><span class="n">dest</span><span class="p">,</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">DestinationSide</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Job</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat</span><span class="p">(</span><span class="n">dest</span><span class="p">,</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">DestinationSide</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">StatDefaultDetails</span></span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">qCDebug</span><span class="p">(</span><span class="n">KIO_COPYJOB_DEBUG</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"CopyJob: stating the dest"</span> <span style="color: #aa2211"><<</span> <span class="n">m_dest</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Fear the same as said for Basic is true with Default. I would prefer explicit flags here as code reader.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25010#inline-141261">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statjob.h:181</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/// @since 5.64</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">constexpr</span> <span style="color: #aa4000">static</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetails</span> <span class="n">StatDefaultDetails</span> <span style="color: #aa2211">=</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetail</span><span style="color: #aa2211">::</span><span class="n">Basic</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetail</span><span style="color: #aa2211">::</span><span class="n">User</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetail</span><span style="color: #aa2211">::</span><span class="n">Time</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetail</span><span style="color: #aa2211">::</span><span class="n">Acl</span> <span style="color: #aa2211">|</span> <span class="n">StatJob</span><span style="color: #aa2211">::</span><span class="n">StatDetail</span><span style="color: #aa2211">::</span><span class="n">ResolveSymlink</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wonder if this should not be rather a member of StatJob, instead of being on generic KIO namespace level.<br />
It feels unbalanced to have the enum being in the class, but a util flag set not.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25010">https://phabricator.kde.org/D25010</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure, kossebau<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>