<table><tr><td style="">dfaure added a subscriber: jriddell.<br />dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24966">View Revision</a></tr></table><br /><div><div><p>Yep, actually I found code in kcmutils (KPluginSelector::Private::PluginDelegate::slotAboutClicked) which sets the program icon name from a plugin (so NOT qApp->windowIcon()) on the aboutData passed to this dialog.<br />
So the functionality kind of made sense, but it was removed and deprecated because KAboutData is in kcoreaddons and can't link to QIcon (commit <a href="https://phabricator.kde.org/R244:62aad4fc37fdc7794e5d059a5897ab1c7eabecdf" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">62aad4fc37fd</a> by <a href="https://phabricator.kde.org/p/jriddell/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jriddell</a>).<br />
I have to wonder about this logic however, as a container for a string, loaded in the above dialog, it was still useful.</p>
<p>The problem is that KAboutData can be about the program (main about data) or about anything else (part, plugin).<br />
For the program, we don't need to set an icon name in KAboutData.<br />
But for parts/plugins, I can see how this was (somewhat) useful.</p>
<p>The above commit deprecated setProgramIconName because KAboutData::setApplicationData can't make use of it, but the code in kaboutapplicationdialog.cpp can.<br />
How about we undeprecate it?<br />
And possibly rename it setIconName...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24966">https://phabricator.kde.org/D24966</a></div></div><br /><div><strong>To: </strong>dfaure, kossebau, elvisangelaccio, vkrause<br /><strong>Cc: </strong>jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>