<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24965">View Revision</a></tr></table><br /><div><div><p>Funnily enough, the 5.39 is irrelevant, since we don't support building with older versions of KConfig. But it becomes relevant because we support enabling one and not the other, as you mention.<br />
We could cheat and just s/38/39/ here, it wouldn't harm anyone.</p>
<p>If we limit *_BUILD_DEPRECATED_SINCE to latest, then my build (with that variable enabled for kwindowsystem) could break at any time when new things get deprecated. But yeah, I'm the 0.1% of people compiling the code, who sets EXCLUDE_DEPRECATED_BEFORE_AND_AT, so I can live with that.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24965">https://phabricator.kde.org/D24965</a></div></div><br /><div><strong>To: </strong>dfaure, kossebau, elvisangelaccio, vkrause<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>