<table><tr><td style="">ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24928">View Revision</a></tr></table><br /><div><div><p>Is cipherDigestMethod() (method @ line 96) needed? the cipher name is inserted in sslMetaData a couple of lines after that.</p>

<p>Using some test code:<br />
QList<QSslCipher> list = QSslConfiguration::supportedCiphers();<br />
for (QSslCipher c  : list) {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">qInfo() << c.name();</pre></div>

<p>}</p>

<p>I get:<br />
"TLS_AES_256_GCM_SHA384"<br />
"TLS_CHACHA20_POLY1305_SHA256"<br />
"TLS_AES_128_GCM_SHA256"<br />
"ECDHE-ECDSA-AES256-GCM-SHA384"<br />
"ECDHE-RSA-AES256-GCM-SHA384"<br />
"DHE-RSA-AES256-GCM-SHA384"<br />
"ECDHE-ECDSA-CHACHA20-POLY1305"<br />
"ECDHE-RSA-CHACHA20-POLY1305"<br />
"DHE-RSA-CHACHA20-POLY1305"<br />
"ECDHE-ECDSA-AES128-GCM-SHA256"<br />
"ECDHE-RSA-AES128-GCM-SHA256"<br />
"DHE-RSA-AES128-GCM-SHA256"<br />
"ECDHE-ECDSA-AES256-SHA384"<br />
"ECDHE-RSA-AES256-SHA384"<br />
"DHE-RSA-AES256-SHA256"<br />
"ECDHE-ECDSA-AES128-SHA256"<br />
"ECDHE-RSA-AES128-SHA256"<br />
"DHE-RSA-AES128-SHA256"<br />
"ECDHE-ECDSA-AES256-SHA"<br />
"ECDHE-RSA-AES256-SHA"<br />
"DHE-RSA-AES256-SHA"<br />
"ECDHE-ECDSA-AES128-SHA"<br />
"ECDHE-RSA-AES128-SHA"<br />
"DHE-RSA-AES128-SHA"<br />
"RSA-PSK-AES256-GCM-SHA384"<br />
"DHE-PSK-AES256-GCM-SHA384"<br />
"RSA-PSK-CHACHA20-POLY1305"<br />
"DHE-PSK-CHACHA20-POLY1305"<br />
"ECDHE-PSK-CHACHA20-POLY1305"<br />
"AES256-GCM-SHA384"<br />
"PSK-AES256-GCM-SHA384"<br />
"PSK-CHACHA20-POLY1305"<br />
"RSA-PSK-AES128-GCM-SHA256"<br />
"DHE-PSK-AES128-GCM-SHA256"<br />
"AES128-GCM-SHA256"<br />
"PSK-AES128-GCM-SHA256"<br />
"AES256-SHA256"<br />
"AES128-SHA256"<br />
"ECDHE-PSK-AES256-CBC-SHA384"<br />
"ECDHE-PSK-AES256-CBC-SHA"<br />
"SRP-RSA-AES-256-CBC-SHA"<br />
"SRP-AES-256-CBC-SHA"<br />
"RSA-PSK-AES256-CBC-SHA384"<br />
"DHE-PSK-AES256-CBC-SHA384"<br />
"RSA-PSK-AES256-CBC-SHA"<br />
"DHE-PSK-AES256-CBC-SHA"<br />
"AES256-SHA"<br />
"PSK-AES256-CBC-SHA384"<br />
"PSK-AES256-CBC-SHA"<br />
"ECDHE-PSK-AES128-CBC-SHA256"<br />
"ECDHE-PSK-AES128-CBC-SHA"<br />
"SRP-RSA-AES-128-CBC-SHA"<br />
"SRP-AES-128-CBC-SHA"<br />
"RSA-PSK-AES128-CBC-SHA256"<br />
"DHE-PSK-AES128-CBC-SHA256"<br />
"RSA-PSK-AES128-CBC-SHA"<br />
"DHE-PSK-AES128-CBC-SHA"<br />
"AES128-SHA"<br />
"PSK-AES128-CBC-SHA256"<br />
"PSK-AES128-CBC-SHA"</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24928">https://phabricator.kde.org/D24928</a></div></div><br /><div><strong>To: </strong>ahmadsamir, dfaure, vkrause<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>