<table><tr><td style="">kmaterka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24755">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D24755#550415" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24755#550415</a>, <a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.</p></div>
</blockquote>
<p>There are two objects in QPA that live independently:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">KDEPlatformSystemTrayIcon (QPlatformSystemTrayIcon), with KSNI instance, KSNI and KDEPlatformSystemTrayIcon <strong>are</strong> destroyed on QSystemTrayIcon->hide() and new instance (with new KSNI) is created on QSystemTrayIcon->show()</li>
<li class="remarkup-list-item">SystemTrayMenu (QPlatformMenu) is <strong>not</strong> destroyed on QSystemTrayIcon->hide() and will be reused later on QSystemTrayIcon->show()</li>
</ul>
<p><a href="https://github.com/KDE/plasma-integration/blob/master/src/platformtheme/kdeplatformsystemtrayicon.cpp#L339" class="remarkup-link" target="_blank" rel="noreferrer">kdeplatformsystemtrayicon.cpp#L339</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu)
{
//...
if (SystemTrayMenu *ourMenu = qobject_cast<SystemTrayMenu*>(menu)) {
m_sni->setContextMenu(ourMenu->menu());
}
}</pre></div>
<p>About you patch: I understand your idea, but it changes API contract and is not backward-compatible. Current documentation says:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The KStatusNotifierItem instance takes ownership of the menu, and will delete it upon its destruction.</p></blockquote>
<p>This is quite clear, I want to be really careful here - I don't want to be blamed for memory leaks :) I think that we need to keep:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>d->menu->setParent(nullptr);</p></blockquote>
<p>in setContextMenu.</p>
<p>Then, to prevent menu deletion, developer needs to explicitly retake ownership, for example:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QMenu *menu = ourMenu->menu()
QWidget *parent = menu->parent();
m_sni->setContextMenu(menu);
menu->setParent(parent);</pre></div>
<p>The problem is that SystemTrayMenu->menu() has no parent and there is no QWidget to use...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24755">https://phabricator.kde.org/D24755</a></div></div><br /><div><strong>To: </strong>kmaterka, Frameworks, davidedmundson, broulik, nicolasfella<br /><strong>Cc: </strong>anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>