<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24841">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24841#inline-140283">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KDECompilerSettings.cmake:208</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #74777d"><span class="bright"># Note that MSVC does not have equivalent flags; the features are either</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #74777d"><span class="bright"># supported or they are not.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">CMAKE_C_COMPILER_ID</span> <span style="color: #766510">STREQUAL</span> <span style="color: #766510">"GNU"</span> <span style="color: #766510">OR</span> <span style="color: #766510">CMAKE_C_COMPILER_ID</span> <span style="color: #766510">MATCHES</span> <span style="color: #766510">"Clang"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d"># We use the C89 standard because that is what is common to all our</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d"># compilers (in particular, MSVC 2010 does not support C99)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CMAKE_C_FLAGS</span> <span style="color: #766510">"${CMAKE_C_FLAGS} -std=iso9899:1990"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">CMAKE_CXX_COMPILER_ID</span> <span style="color: #766510">STREQUAL</span> <span style="color: #766510">"GNU"</span> <span style="color: #766510">OR</span> <span style="color: #766510">CMAKE_CXX_COMPILER_ID</span> <span style="color: #766510">MATCHES</span> <span style="color: #766510">"Clang"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CMAKE_CXX_FLAGS</span> <span style="color: #766510">"${CMAKE_CXX_FLAGS} -std=c++0x"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">elseif</span> <span class="p">(</span><span style="color: #766510">CMAKE_CXX_COMPILER_ID</span> <span style="color: #766510">STREQUAL</span> <span style="color: #766510">"Intel"</span> <span style="color: #766510">AND</span> <span style="color: #766510">NOT</span> <span style="color: #766510">WIN32</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CMAKE_CXX_FLAGS</span> <span style="color: #766510">"${CMAKE_CXX_FLAGS} -std=c++0x"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">set</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">CMAKE_C_STANDARD</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">90</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">set</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">CMAKE_CXX_STANDARD_REQUIRED</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">11</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's not how it works.<br />
You want</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED TRUE)</pre></div>
<p style="padding: 0; margin: 8px;">Note however that these require CMake >= 3.1, while ECM says <tt style="background: #ebebeb; font-size: 13px;">cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)</tt>. I do however thing that ECM *should* require 3.1.<br />
I doubt it's been tested on 2.8.x in ages, and 3.1 is really a common requirement these days.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24841">https://phabricator.kde.org/D24841</a></div></div><br /><div><strong>To: </strong>vonreth, dfaure, cullmann<br /><strong>Cc: </strong>chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>