<table><tr><td style="">leinir accepted this revision.<br />leinir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24681">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D24681#547798" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24681#547798</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT, as some deprecated API is still used internally, so this needs more clean-up by someone(tm) first.</p></div>
</blockquote>
<p>It's indeed annoying, and i've been trying to get rid of the internal usage (i do very much like clean build output), but of course it's just not that straightforward, and in particular things like where things in KNS have been deprecated in favour of things in KNSCore we can't just get rid, because getting rid of that would cause havoc with BCI. Basically a bunch of TODO KF6 things :P</p>
<p>But, apart from that, yes, this is really good work, and whether or not that's in, definitely fire away :) i especially like the second half of those "don't use this, use THIS" bits :D</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>BRANCH</strong><div><div>useECMGenerateExportHeader</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24681">https://phabricator.kde.org/D24681</a></div></div><br /><div><strong>To: </strong>kossebau, Frameworks, leinir, mlaurent<br /><strong>Cc: </strong>mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>