<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24746">View Revision</a></tr></table><br /><div><div><p>In principle I like the idea of customizing the display to be more appropriate. However I feel like the best way to do this might be to go in a different direction: instead of adding overrides for <tt style="background: #ebebeb; font-size: 13px;">/</tt>, maybe we should take advantage of the fact that <tt style="background: #ebebeb; font-size: 13px;">/</tt> is always a mounted volume and instead make the properties dialog reflect the name and icon of the disk in question. Otherwise when you look at the properties for that disk, the dialog that appears shows a different name and icon from the thing that was clicked on.</p>
<p><a href="https://phabricator.kde.org/F7623965" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7623965: Screenshot_20191018_120133.png</a></p>
<p>If we improve the properties dialog for disks in general, that will also improve the display for other kinds of disks and mounted volumes.</p>
<p>What do you think?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>kpropertiesdialog-root-directory (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24746">https://phabricator.kde.org/D24746</a></div></div><br /><div><strong>To: </strong>tienisto, VDG, ngraham, Frameworks, GB_2<br /><strong>Cc: </strong>meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>