<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24568">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24568#inline-139515">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">clang-format.cmake:75</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">typo: ternary</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I've been always wondering how one should break long ternary operators when writing KF code. There are several ways to do it</p>

<p style="padding: 0; margin: 8px;">(a) w/o breaking (BreakBeforeTernaryOperators: false)</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span class="n">FooBar</span> <span style="color: #aa2211">*</span><span class="n">foobar</span> <span style="color: #aa2211">=</span> <span class="n">someStupidCondition</span><span class="p">()</span> <span style="color: #aa2211">?</span>
    <span class="n">someSuperDuperBeatifulFunctionWithLongName</span><span class="p">()</span> <span style="color: #aa2211">:</span>
    <span class="n">anotherSuperDuperBeatifuuuulFunctionWithLongName</span><span class="p">();</span></pre></div>

<p style="padding: 0; margin: 8px;">(b) w/ breaking (BreakBeforeTernaryOperators: true)</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span class="n">FooBar</span> <span style="color: #aa2211">*</span><span class="n">foobar</span> <span style="color: #aa2211">=</span> <span class="n">someStupidCondition</span><span class="p">()</span>
    <span style="color: #aa2211">?</span> <span class="n">someSuperDuperBeatifulFunctionWithLongName</span><span class="p">()</span>
    <span style="color: #aa2211">:</span> <span class="n">anotherSuperDuperBeatifuuuulFunctionWithLongName</span><span class="p">();</span></pre></div>

<p style="padding: 0; margin: 8px;">According to the _clang-format file from the qt5 super repo, Qt fellas prefer (b) to break before ternary operators.</p>

<p style="padding: 0; margin: 8px;">Do we really want to not break before ternary opeartors?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24568">https://phabricator.kde.org/D24568</a></div></div><br /><div><strong>To: </strong>cullmann, Frameworks, dfaure<br /><strong>Cc: </strong>zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>