<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24663">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24663#inline-139403">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">plasmawindowmanagement_interface.cpp:741</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.</p>
<p style="padding: 0; margin: 8px;">Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in the commit message:<br />
"No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by<br />
someone with detailed knowledge about disabling implementation, if wanted."</p>
<p style="padding: 0; margin: 8px;">I tried to add it, but too much API got deprecated yet still kept being used internally. So a version-levelled disabling of implementation is not yet possible, first needs more cleanup of the internal usages.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24663">https://phabricator.kde.org/D24663</a></div></div><br /><div><strong>To: </strong>kossebau, KWin<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>