<table><tr><td style="">cullmann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24568">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D24568#548490" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24568#548490</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Do we want these, found in <a href="https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format" class="remarkup-link" target="_blank" rel="noreferrer">https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format</a>?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"># We use template< without space.
SpaceAfterTemplateKeyword: false
# macros for which the opening brace stays attached.
ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, QBENCHMARK, QBENCHMARK_ONCE ]
# Break constructor initializers before the colon and after the commas.
BreakConstructorInitializers: BeforeColon</pre></div></div>
</blockquote>
<p>added that</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>In general, I'm curious why we're not using qt5's clang-format file, with our only difference (braces for single-line statements) on top?</p></blockquote>
<p>I was more comfortable tweaking the file I created some years ago (and updated for all clang-format versions since then) that should be close to the kdelibs style than trying to take a look in detail at the other one, to be honest ;=)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24568#inline-139520">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDEClangFormat.cmake:76</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I wonder if people compiling KF5 modules (and not necessarily planning on contributing) need to be annoyed with such a warning. Maybe we could still define the clang-format target and make it print an error?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yeah, I think some message on running the target will be less annoying.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24568#inline-139518">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">clang-format.cmake:43</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I'm confused because here it says "true" will group via empty lines, while <a href="https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format" class="remarkup-link" target="_blank" rel="noreferrer">https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format</a> says <tt style="background: #ebebeb; font-size: 13px;">the SortInclude feature of clang-format does not re-order includes separated by empty lines</tt>. Maybe different versions of clang-format? Or I misunderstand something?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Perhaps my comment is not understandable.<br />
true means clang-format will sort stuff inside #include groups (aka #include lines without empty lines in-between)<br />
Will alter the comment.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24568#inline-139517">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">clang-format.cmake:49</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><a href="https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format" class="remarkup-link" target="_blank" rel="noreferrer">https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format</a> says <tt style="background: #ebebeb; font-size: 13px;">PointerBindsToType: false</tt>, what's the difference?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">My file is for some recent clang, whereas PointerBindsToType seems to be ancient, see:</p>
<p style="padding: 0; margin: 8px;"><a href="https://releases.llvm.org/3.4/tools/clang/docs/ClangFormatStyleOptions.html" class="remarkup-link" target="_blank" rel="noreferrer">https://releases.llvm.org/3.4/tools/clang/docs/ClangFormatStyleOptions.html</a> (there you still have that)</p>
<p style="padding: 0; margin: 8px;"><a href="http://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html" class="remarkup-link" target="_blank" rel="noreferrer">http://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html</a> (here I can only find the variant I use)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24568">https://phabricator.kde.org/D24568</a></div></div><br /><div><strong>To: </strong>cullmann, Frameworks, dfaure<br /><strong>Cc: </strong>mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>