<table><tr><td style="">zzag created this revision.<br />zzag added a reviewer: Frameworks.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />zzag requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24629">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The new class provides a way for monitoring system clock changes. This<br />
class can be useful for applications that build their logic around time,<br />
for example dynamic wallpapers, so reacting to system clock changes is<br />
quite crucial for them.</p>
<p>The new class can also be useful for Night Color in KWin and time data<br />
engine as they two don't have support for FreeBSD. KClockSkewNotifier<br />
also doesn't have support for FreeBSD at this moment, however when it<br />
gains that, we'll have to patch only one place rather than two.</p>
<p>All good stuff happens in so called "notifier engines." A notifier<br />
engine is responsible for detecting system clock changes and all<br />
platform-specific code must reside there. KClockSkewNotifier is just a<br />
thin wrapper around the corresponding engine, which is loaded and<br />
unloaded as needed.</p>
<p>In long term, we need to add a couple more notifier engines. One for<br />
Windows(?), one for FreeBSD(?), and one that doesn't use any platform<br />
specific APIs but QTimer.</p>
<p>"KClockSkewNotifier" is not the best name. I'm open to suggestions.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>No autotests because setting time requires root privileges.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>BRANCH</strong><div><div>kclockskewnotifier</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24629">https://phabricator.kde.org/D24629</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/lib/CMakeLists.txt<br />
src/lib/clock/kclockskewnotifier.cpp<br />
src/lib/clock/kclockskewnotifier.h<br />
src/lib/clock/kclockskewnotifierengine.cpp<br />
src/lib/clock/kclockskewnotifierengine_linux.cpp<br />
src/lib/clock/kclockskewnotifierengine_linux_p.h<br />
src/lib/clock/kclockskewnotifierengine_p.h</div></div></div><br /><div><strong>To: </strong>zzag, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>