<table><tr><td style="">kossebau updated this revision to Diff 67803.<br />kossebau marked an inline comment as done.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23802">View Revision</a></tr></table><br /><div><div><p>add missing #if/#endif for KToolInvocation::invokeBrowser</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R309 KService</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D23802?vs=67731&id=67803">https://phabricator.kde.org/D23802?vs=67731&id=67803</a></div></div><br /><div><strong>BRANCH</strong><div><div>useECMGenerateExportHeader</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23802">https://phabricator.kde.org/D23802</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
autotests/CMakeLists.txt<br />
autotests/kplugininfotest.cpp<br />
autotests/kservicetest.cpp<br />
autotests/kservicetest.h<br />
src/CMakeLists.txt<br />
src/kdeinit/ktoolinvocation.cpp<br />
src/kdeinit/ktoolinvocation.h<br />
src/kdeinit/ktoolinvocation_win.cpp<br />
src/kdeinit/ktoolinvocation_x11.cpp<br />
src/plugin/kdbusservicestarter.cpp<br />
src/plugin/kdbusservicestarter.h<br />
src/services/kplugininfo.cpp<br />
src/services/kplugininfo.h<br />
src/services/kservice.h<br />
src/sycoca/ksycoca.cpp<br />
src/sycoca/ksycoca.h<br />
tests/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>kossebau, Frameworks, dfaure, mlaurent<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>