<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22362">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22362#493722" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22362#493722</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>As some background:</p>
<p>At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experience adding a protocol to Qt was relatively painless.</p>
<p>We said we'd try on a really simple protocol.</p>
<p>IMHO this looks encouraging.</p>
<p>Obviously having a mix of styles isn't great, but something has to be first.</p>
<hr class="remarkup-hr" />
<p>One thing we need to resolve is</p>
<p>QtWaylandServer::org_kde_kwin_keystate</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">will call init which will call wl_global_create</pre></div>
<p>Global::Private will call wl_global_create</p>
<p>Calling that twice is wrong.</p></div>
</blockquote>
<p>I was looking into this and realised it's not really easy to solve. The reason is that KWayland::Server::Global was designed to be able to expose the wl_global as if it was useful, but this is something you never do. The wl_global is private on the generated code so we can't access it. I'll provide a workaround for now to keep the conversation alive, but I'd say at least <tt style="background: #ebebeb; font-size: 13px;">operator wl_global*();</tt> should get deprecated.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22362">https://phabricator.kde.org/D22362</a></div></div><br /><div><strong>To: </strong>apol, KWin<br /><strong>Cc: </strong>davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>