<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7446">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7446#542407" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D7446#542407</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>This commit breaks <tt style="background: #ebebeb; font-size: 13px;">kfileplacesmodeltest</tt>, please take a look.</p>
<p><a href="https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/</a></p></div>
</blockquote>
<p>See fix in <a href="https://phabricator.kde.org/D24439" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24439</a></p>
<p>The second failure seems to me sporadic, or at least not related :</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Expected: ("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/floppy0", "/media/XO-Y4", "/media/cdrom")
QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Got: ("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/cdrom", "/media/floppy0", "/media/XO-Y4")
FAIL! : KFilePlacesModelTest::testPlaceGroupHidden() Compared lists differ at index 5.
Actual (placesUrls()): "/media/cdrom"
Expected (urls): "/media/floppy0"
Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/autotests/kfileplacesmodeltest.cpp(1091)]</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7446">https://phabricator.kde.org/D7446</a></div></div><br /><div><strong>To: </strong>meven, Dolphin, broulik, elvisangelaccio, VDG, Frameworks, ngraham<br /><strong>Cc: </strong>meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, Konqueror, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>