<table><tr><td style="">sitter created this revision.<br />Herald added projects: Dolphin, Frameworks.<br />Herald added subscribers: kfm-devel, kde-frameworks-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24387">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>previously we'd not forward the errors coming out of the password dialog<br />
helper and instead eventually end up on generic access denied errors.<br />
seeing as the access denied is likely because we couldn't query auth info<br />
that is fairly misleading.</p>
<p>checkPassword is now returning an error code instead of a bool. when we<br />
actually consider checkPassword an error we'll now raise this error<br />
instead of the generic access denied errors. when the user canceled<br />
the query we'll continue to raise the more topical error from smb (e.g.<br />
"access denied")</p>
<p>primarily these errors appear when kiod/kpasswdserver is defunct<br />
or not installed meaning query functionality will not work at all.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ol class="remarkup-list">
<li class="remarkup-list-item">broken kiod</li>
<li class="remarkup-list-item">remove dbus service file</li>
<li class="remarkup-list-item">kill</li>
<li class="remarkup-list-item">dolphin smb://host</li>
<li class="remarkup-list-item">no auth query</li>
<li class="remarkup-list-item">error about broken dialog</li>
</ol>
<ol class="remarkup-list">
<li class="remarkup-list-item">cancel</li>
<li class="remarkup-list-item">repair kiod</li>
<li class="remarkup-list-item">dolphin smb://host</li>
<li class="remarkup-list-item">auth query</li>
<li class="remarkup-list-item">cancel</li>
<li class="remarkup-list-item">auth query</li>
<li class="remarkup-list-item">cancel</li>
<li class="remarkup-list-item">error about access denied (because refused to authenticate)</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>BRANCH</strong><div><div>Applications/19.08</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24387">https://phabricator.kde.org/D24387</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>smb/kio_smb.h<br />
smb/kio_smb_auth.cpp<br />
smb/kio_smb_browse.cpp<br />
smb/kio_smb_mount.cpp</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>