<table><tr><td style="">bruns requested changes to this revision.<br />bruns added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23787">View Revision</a></tr></table><br /><div><div><p>Can you please provide an example which:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">is currently indexed though it should be skipped due to size</li>
<li class="remarkup-list-item">is skipped after this change</li>
</ul>

<p>and another example which:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">is currently skipped though it should be indexed</li>
<li class="remarkup-list-item">is indexed after this change</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23787#inline-137127">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:184</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// have trouble processing them</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">ex</span><span style="color: #aa2211">-></span><span class="n">extractorProperties</span><span class="p">()[</span><span style="color: #766510">"Name"</span><span class="p">].</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"PlaintextExtractor"</span><span class="p">))</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">filesize</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">10</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1024</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1024</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">qCWarning</span><span class="p">(</span><span class="n">BALOO</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Skipping"</span> <span style="color: #aa2211"><<</span> <span class="n">url</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">": large plain text file"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You should compare for size first, as that's much cheaper than fetching the property and comparing  the string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23787#inline-137126">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">ex</span><span style="color: #aa2211">-></span><span class="n">extractorProperties</span><span class="p">()[</span><span style="color: #766510">"Name"</span><span class="p">].</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"PlaintextExtractor"</span><span class="p">))</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">filesize</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">10</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1024</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1024</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">qCWarning</span><span class="p">(</span><span class="n">BALOO</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Skipping"</span> <span style="color: #aa2211"><<</span> <span class="n">url</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">": large plain text file"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">continue</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Users will love us for spammig the logs ...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23787">https://phabricator.kde.org/D23787</a></div></div><br /><div><strong>To: </strong>poboiko, Baloo, bruns, ngraham<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, Baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>