<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: bruns, kossebau.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24160">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This was done using clang-tidy's modernize-loop-convert, then<br />

clazy (for qAsConst), then manual cleanups (less auto, better variable<br />

names, etc). Took way longer than I was hoping for...</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>make && ctest</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24160">https://phabricator.kde.org/D24160</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kfileplacesmodeltest.cpp<br />

src/core/authinfo.cpp<br />

src/core/desktopexecparser.cpp<br />

src/core/hostinfo.cpp<br />

src/core/kcoredirlister.cpp<br />

src/core/kioglobal_p.cpp<br />

src/core/kmountpoint.cpp<br />

src/core/kprotocolmanager.cpp<br />

src/core/krecentdocument.cpp<br />

src/core/ksambashare.cpp<br />

src/core/ksslcertificatemanager.cpp<br />

src/core/slave.cpp<br />

src/core/udsentry.cpp<br />

src/filewidgets/kdirsortfilterproxymodel.cpp<br />

src/filewidgets/knewfilemenu.cpp<br />

src/ioslaves/help/kio_help.cpp<br />

src/ioslaves/http/http.cpp<br />

src/ioslaves/trash/kio_trash.cpp<br />

src/ioslaves/trash/tests/testtrash.cpp<br />

src/ioslaves/trash/trashimpl.cpp<br />

src/kcms/kio/smbrodlg.cpp<br />

src/kcms/webshortcuts/main.cpp<br />

src/kiod/kiod_main.cpp<br />

src/kntlm/kntlm.cpp<br />

src/kpac/proxyscout.cpp<br />

src/kssld/kssld.cpp<br />

src/urifilters/ikws/kuriikwsfiltereng.cpp<br />

src/widgets/dropjob.cpp<br />

src/widgets/fileundomanager.cpp<br />

src/widgets/kfileitemdelegate.cpp<br />

src/widgets/kopenwithdialog.cpp<br />

src/widgets/kpropertiesdialog.cpp<br />

src/widgets/krun.cpp<br />

src/widgets/kshellcompletion.cpp<br />

src/widgets/ksslinfodialog.cpp<br />

src/widgets/kurifilter.cpp<br />

src/widgets/kurlcompletion.cpp<br />

src/widgets/kurlrequester.cpp<br />

src/widgets/previewjob.cpp<br />

tests/getalltest.cpp<br />

tests/previewtest.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, bruns, kossebau<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>