<table><tr><td style="">kossebau updated this revision to Diff 66670.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23789">View Revision</a></tr></table><br /><div><div><p>add first set of unit tests covering the main functionality.<br />
Feedback on principal approach wanted!</p>

<p>Also add some fixes to actual macro code found by the tests already :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D23789?vs=65854&id=66670">https://phabricator.kde.org/D23789?vs=65854&id=66670</a></div></div><br /><div><strong>BRANCH</strong><div><div>addgenerateexportheader</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23789">https://phabricator.kde.org/D23789</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>docs/module/ECMGenerateExportHeader.rst<br />
modules/ECMGenerateExportHeader.cmake<br />
tests/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/consumer/main.cpp<br />
tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/format_version/main.cpp<br />
tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/library/library.cpp<br />
tests/ECMGenerateExportHeaderTest/library/library.hpp<br />
tests/ECMGenerateExportHeaderTest/library/main.cpp</div></div></div><br /><div><strong>To: </strong>kossebau<br /><strong>Cc: </strong>chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>