<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23942">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23942#531279" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23942#531279</a>, <a href="https://phabricator.kde.org/p/guoyunhe/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@guoyunhe</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a>, I made some change. Can you have another look?</p></div>
</blockquote>
<p>I just noticed that the "No" symbol is backwards. Once you fix that and the hardcoded colors, this patch will be ready to land.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23942#inline-135474">View Inline</a><span style="color: #4b4d51; font-weight: bold;">font-disable.svg:11</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-Text" d="m6.3828 2-4.3828 11h1.3574l1.1895-3h2.4531 2.3418a3.5 3.5 0 0 1 1.0234-1.2715l-2.6797-6.7285h-0.68555-0.61719zm0.62305 1.3281 2.1211 5.6719h-2.127-2.0586c-0.00124 0.00746 2.0645-5.6719 2.0645-5.6719z" fill="currentColor"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-NegativeText" d="m12.5 9a2.5 2.5 0 0 0-2.5 2.5 2.5 2.5 0 0 0 2.5 2.5 2.5 2.5 0 0 0 2.5-2.5 2.5 2.5 0 0 0-2.5-2.5m0 1a1.5 1.5 0 0 1 0.64453 0.14844l-1.9965 1.9966a1.5 1.5 0 0 1-0.148-0.645 1.5 1.5 0 0 1 1.5-1.5m1.3516 0.85547a1.5 1.5 0 0 1 0.14844 0.64453 1.5 1.5 0 0 1-1.5 1.5 1.5 1.5 0 0 1-0.64453-0.14844z" fill="#da4453"/>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoded color</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23942#inline-135473">View Inline</a><span style="color: #4b4d51; font-weight: bold;">font-disable.svg:10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> </style>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-NegativeText" d="m16 13c-1.662 0-3 1.338-3 3s1.338 3 3 3 3-1.338 3-3-1.338-3-3-3zm0 1c0.37162 0 0.7142 0.10606 1.0117 0.28125l-2.7305 2.7305c-0.17518-0.29752-0.28125-0.64009-0.28125-1.0117 0-1.108 0.892-2 2-2zm1.7188 0.98828c0.17518 0.29752 0.28125 0.64009 0.28125 1.0117 0 1.108-0.892 2-2 2-0.37162 0-0.7142-0.10606-1.0117-0.28125z" fill="#da4453"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-Text" d="m7.9102 3-3.3145 9.5938-0.12305 0.40625-1.4727 4h1.6582l1.625-4.4375h5.4336l0.65039 1.7754a4 4 0 0 1 1.125-1.4531l-0.087891-0.29102-3.3145-9.5938h-0.21484-1.75-0.21484zm1.1055 1.9375 2.1797 6.3438h-4.3906l2.2109-6.3438z" fill="currentColor"/>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoded color</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23942#inline-135471">View Inline</a><span style="color: #4b4d51; font-weight: bold;">font-disable.svg:11</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-Text" d="m6.3828 2-4.3828 11h1.3574l1.1895-3h2.4531 2.3418a3.5 3.5 0 0 1 1.0234-1.2715l-2.6797-6.7285h-0.68555-0.61719zm0.62305 1.3281 2.1211 5.6719h-2.127-2.0586c-0.00124 0.00746 2.0645-5.6719 2.0645-5.6719z" fill="currentColor"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-NegativeText" d="m12.5 9a2.5 2.5 0 0 0-2.5 2.5 2.5 2.5 0 0 0 2.5 2.5 2.5 2.5 0 0 0 2.5-2.5 2.5 2.5 0 0 0-2.5-2.5m0 1a1.5 1.5 0 0 1 0.64453 0.14844l-1.9965 1.9966a1.5 1.5 0 0 1-0.148-0.645 1.5 1.5 0 0 1 1.5-1.5m1.3516 0.85547a1.5 1.5 0 0 1 0.14844 0.64453 1.5 1.5 0 0 1-1.5 1.5 1.5 1.5 0 0 1-0.64453-0.14844z" fill="#da4453"/>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoded color</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23942#inline-135472">View Inline</a><span style="color: #4b4d51; font-weight: bold;">font-disable.svg:10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> </style>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-NegativeText" d="m16 13c-1.662 0-3 1.338-3 3s1.338 3 3 3 3-1.338 3-3-1.338-3-3-3zm0 1c0.37162 0 0.7142 0.10606 1.0117 0.28125l-2.7305 2.7305c-0.17518-0.29752-0.28125-0.64009-0.28125-1.0117 0-1.108 0.892-2 2-2zm1.7188 0.98828c0.17518 0.29752 0.28125 0.64009 0.28125 1.0117 0 1.108-0.892 2-2 2-0.37162 0-0.7142-0.10606-1.0117-0.28125z" fill="#da4453"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path class="ColorScheme-Text" d="m7.9102 3-3.3145 9.5938-0.12305 0.40625-1.4727 4h1.6582l1.625-4.4375h5.4336l0.65039 1.7754a4 4 0 0 1 1.125-1.4531l-0.087891-0.29102-3.3145-9.5938h-0.21484-1.75-0.21484zm1.1055 1.9375 2.1797 6.3438h-4.3906l2.2109-6.3438z" fill="currentColor"/>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoded color</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23942">https://phabricator.kde.org/D23942</a></div></div><br /><div><strong>To: </strong>guoyunhe, Breeze, ndavis<br /><strong>Cc: </strong>ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>