<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23899">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23899#inline-135091">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwalletd.cpp:636</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">kpd</span><span style="color: #aa2211">-></span><span class="n">setWindowTitle</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"KDE Wallet Service"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">kpd</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KIconLoader</span><span style="color: #aa2211">::</span><span class="n">global</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">loadIcon</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kwalletmanager"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KIconLoader</span><span style="color: #aa2211">::</span><span class="n">Desktop</span><span class="p">,</span> <span class="n">KIconLoader</span><span style="color: #aa2211">::</span><span class="n">SizeHuge</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">kpd</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"kwalletmanager"</span></span><span class="bright"></span><span class="p"><span class="bright">)).</span></span><span class="bright"></span><span class="n"><span class="bright">pixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">64</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">w</span> <span style="color: #aa2211">!=</span> <span class="n">KWindowSystem</span><span style="color: #aa2211">::</span><span class="n">activeWindow</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">w</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0L</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The 64 seems a bit too hardcoded, and KPasswordDialog internally defaults to <tt style="background: #ebebeb; font-size: 13px;">q->style()->pixelMetric(QStyle::PM_MessageBoxIconSize, &option, q)</tt> (when setPixmap isn't called).</p>
<p style="padding: 0; margin: 8px;">I think the first step is to add a setIcon to KPasswordDialog.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23899#inline-135092">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwalletwizard.cpp:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ui</span><span class="p">.</span><span class="n">ktitlewidget</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span style="color: #766510">"<h1>"</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"KWallet"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"</h1>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">iconSize</span> <span style="color: #aa2211">=</span> <span style="color: #601200">3</span> <span style="color: #aa2211">*</span> <span class="n">fontMetrics</span><span class="p">().</span><span class="n">height</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">// round to multiple of 16</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">iconSize</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">iconSize</span> <span style="color: #aa2211">+</span> <span style="color: #601200">8</span><span class="p">)</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">~</span><span style="color: #601200">15</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QPixmap</span> <span class="n">pix</span> <span style="color: #aa2211">=</span> <span class="n">KIconLoader</span><span style="color: #aa2211">::</span><span class="n">global</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">loadIcon</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kwalletmanager"</span><span class="p">),</span> <span class="n">KIconLoader</span><span style="color: #aa2211">::</span><span class="n">Dialog</span><span class="p">,</span> <span class="n">iconSize</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">ui</span><span class="p">.</span><span class="n">ktitlewidget</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(</span><span class="n">pix</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n"><span class="bright">ui</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">ktitlewidget</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setPixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"kwalletmanager"</span></span><span class="bright"></span><span class="p"><span class="bright">)));</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(we should add a setIcon overload to KTitleWidget, this setPixmap method is misnamed).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R311 KWallet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23899">https://phabricator.kde.org/D23899</a></div></div><br /><div><strong>To: </strong>vkrause, davidedmundson, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>