<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11987">View Revision</a></tr></table><br /><div><div><p>My version is up at <a href="https://phabricator.kde.org/D23758" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D23758</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11987#inline-134356">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:2097</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// which is why we're passing m_currentSrcURL instead of m_currentStatSrc to it</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">emit</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">copyingDone</span><span class="p">(</span><span class="n">q</span><span class="p">,</span> <span style="color: #aa2211">*</span><span class="n">m_currentStatSrc</span><span class="p">,</span> <span class="n">finalDestUrl</span><span class="p">(</span><span class="n">m_currentSrcURL</span><span class="p">,</span> <span class="n">dest</span><span class="p">),</span> <span class="n">QDateTime</span><span class="p">()</span> <span style="color: #74777d">/*mtime unknown, and not needed*/</span><span class="p">,</span> <span class="n">m_bCurrentSrcIsDir</span><span class="p">,</span> <span style="color: #304a96">true</span> <span style="color: #74777d">/*renamed*/</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">m_successSrcList</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">m_currentStatSrc</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this really the version of the fix that worked for you?</p>

<p style="padding: 0; margin: 8px;">It seems to me that the second arg needs to be m_currentSrcURL too, otherwise FileUndoManager tries to call KIO::rename("trash:/...", "desktop:/...") which isn't supported by the trash ioslave.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11987">https://phabricator.kde.org/D11987</a></div></div><br /><div><strong>To: </strong>broulik, Frameworks, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns<br /></div>