<table><tr><td style="">jgrulich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23713">View Revision</a></tr></table><br /><div><div><p>I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23713#inline-133994">View Inline</a><span style="color: #4b4d51; font-weight: bold;">strongswanwidget.cpp:100</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">ipComp</span><span style="color: #aa2211">-></span><span class="n">setChecked</span><span class="p">(</span><span class="n">dataMap</span><span class="p">[</span><span class="n">NM_STRONGSWAN_IPCOMP</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"yes"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">proposal</span><span style="color: #aa2211">-></span><span class="n">setChecked</span><span class="p">(</span><span class="n">dataMap</span><span class="p">[</span><span class="n">NM_STRONGSWAN_PROPOSAL</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"yes"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">ike</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">dataMap</span><span class="p">[</span><span class="n">NM_STRONGSWAN_IKE</span><span class="p">]);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same here, probably pointless to set "IKE" and "ESP" when "Enable custom proposals" is false.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23713#inline-133970">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pino</span> wrote in <span style="color: #4b4d51; font-weight: bold;">strongswanwidget.cpp:155-156</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">should these be set only when the custom proposals are accepted?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indeed, they should be set only when the "Enable custom proposals" checkbox  is checked.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23713">https://phabricator.kde.org/D23713</a></div></div><br /><div><strong>To: </strong>rrichmond, fvogt, jgrulich<br /><strong>Cc: </strong>pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>