<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22069">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22069#523824" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22069#523824</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>If what you're saying is that that you run ./bin/ki18n-klocalizedstringtest without those lines and the test fails for you, well you'll have to give me access to your machine since i can't fix what i can't debug (i.e. it works fine here)</p></div>
</blockquote>
<p>Yes that is exactly what I'm saying:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">~/kde/src/ki18n$ (localized-long-number-strings) ../../build/ki18n/bin/ki18n-klocalizedstringtest
********* Start testing of KLocalizedStringTest *********
Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.1.0)
PASS : KLocalizedStringTest::initTestCase()
FAIL! : KLocalizedStringTest::correctSubs() Compared values are not the same
Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
Expected (QString(" 4,20")) : " 4,20"
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)]
PASS : KLocalizedStringTest::wrongSubs()
PASS : KLocalizedStringTest::removeAcceleratorMarker()
PASS : KLocalizedStringTest::miscMethods()
SKIP : KLocalizedStringTest::translateToFrenchLowlevel() French test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(466)]
SKIP : KLocalizedStringTest::translateToFrench() French test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(479)]
PASS : KLocalizedStringTest::translateQt()
SKIP : KLocalizedStringTest::addCustomDomainPath() French test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(536)]
SKIP : KLocalizedStringTest::testThreads() French test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(479)]
FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same
Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
Expected (QString(" 4,20")) : " 4,20"
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)]
FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same
Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
Expected (QString(" 4,20")) : " 4,20"
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)]
FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same
Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
Expected (QString(" 4,20")) : " 4,20"
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)]
SKIP : KLocalizedStringTest::testLocalizedTranslator() French test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(511)]
QWARN : KLocalizedStringTest::semanticTags() "Tag 'numid' is not defined in message {<__kuit_internal_top__>Connecting to <numid>22</numid>...</__kuit_internal_top__...}."
XFAIL : KLocalizedStringTest::semanticTags() what happened to <numid/>? TODO.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(351)]
PASS : KLocalizedStringTest::semanticTags()
SKIP : KLocalizedStringTest::multipleLanguages() French or Catalan test files not usable.
Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(550)]
PASS : KLocalizedStringTest::cleanupTestCase()
Totals: 7 passed, 4 failed, 6 skipped, 0 blacklisted, 20ms
********* Finished testing of KLocalizedStringTest *********</pre></div>
<p>Unfortunately I won't be able to make it to Akademy next week so I'm not sure when will be the next time for us to share a room.</p>
<p>If the code with your proposed removal looks good to you and you're confident that thee issue is a local mis-configuration on my side, can I land the patch?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R249 KI18n</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22069">https://phabricator.kde.org/D22069</a></div></div><br /><div><strong>To: </strong>ngraham, Localization, Frameworks, broulik<br /><strong>Cc: </strong>aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>