<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21760">View Revision</a></tr></table><br /><div><div><p>Nice job. Final comments.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21760#inline-133701">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klistopenfilestest_unix.cpp:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">processInfoAvailableSpy</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QString</span><span style="color: #aa2211">></span><span class="p">(),</span> <span class="n">path</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KProcessList</span><span style="color: #aa2211">::</span><span class="n">KProcessInfoList</span> <span class="n">processInfoList</span> <span style="color: #aa2211">=</span> <span class="n">processInfoAvailableSpy</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">KProcessList</span><span style="color: #aa2211">::</span><span class="n">KProcessInfoList</span><span style="color: #aa2211">></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">processInfoList</span><span class="p">.</span><span class="n">empty</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">prepend <tt style="background: #ebebeb; font-size: 13px;">const</tt> so begin/end below don't detach</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21760#inline-133702">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klistopenfilestest_unix.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QTemporaryDir</span> <span class="n">tempDir</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">tempDir</span><span class="p">.</span><span class="n">remove</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KListOpenFiles</span><span style="color: #aa2211">::</span><span class="n">listProcessesWithOpenFiles</span><span class="p">(</span><span class="n">tempDir</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I usually just use "/does/not/exist" as a path ;-)</p>

<p style="padding: 0; margin: 8px;">This might actually be better because Windows has weird race conditions with the filesystem stuff.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21760#inline-133706">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klistopenfiles.h:94</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KCOREADDONS_EXPORT</span> <span class="n">ListOpenFilesJob</span> <span style="color: #aa2211">*</span><span style="color: #004012">listProcessesWithOpenFiles</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">path</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KIO is designed like this for some reason, but I would just document the job constructor and let people create the job with new, outside KIO.</p>

<p style="padding: 0; margin: 8px;">That's e.g. what akonadi does.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21760">https://phabricator.kde.org/D21760</a></div></div><br /><div><strong>To: </strong>hallas, davidedmundson, broulik, Frameworks, dfaure, bruns, Plasma<br /><strong>Cc: </strong>meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>