<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23576">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23576#522341" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23576#522341</a>, <a href="https://phabricator.kde.org/p/jgrulich/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jgrulich</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23576#522340" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23576#522340</a>, <a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives.<br />
This would be used to compute the time elapsed between the scans which is necessary to do since Network manager requires scans to be at least 10 seconds apart :<br />
<a href="https://github.com/NetworkManager/NetworkManager/blob/master/src/devices/wifi/nm-device-wifi.c#L1205" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/NetworkManager/NetworkManager/blob/master/src/devices/wifi/nm-device-wifi.c#L1205</a></p></div>
</blockquote>
<p>That would be useful I guess and could be used in plasma-nm.</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">You should set initial lastScan property to "-1" which should indicate there was no scan attempt</li>
<li class="remarkup-list-item">Mention that it will work only when NM 1.12+ is running, older NM releases don't support this property</li>
<li class="remarkup-list-item">Above mentioned will be a problem when you would like to rely on that in plasma-nm, because we should be working even with older NM versions</li>
</ol></div>
</blockquote>
<ol class="remarkup-list">
<li class="remarkup-list-item">I missed your comment and made important code change, instead of using the LastScan property, I use QDateTime to retain requestScan event and LastScan changes event.</li>
</ol>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">will do</li>
</ol>
<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">My code in plasma should be compatible already <a href="https://phabricator.kde.org/D23578" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23578</a></li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23576#inline-133268">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">wirelessdevice.cpp:250</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Don't use QDateTime::currentDateTime() as it might be different from the actual value returned by NetworkManager.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">LastScan is in CLOCK_BOOTIME which is complicated to work with.<br />
So I use naively the signal time rather than the LastScan value.<br />
This will need a bit of work just to work with it:<br />
<a href="https://github.com/NetworkManager/NetworkManager/blob/a7d8fe0ea5eb7be42a86527226ea54fd221fb1b4/shared/nm-glib-aux/nm-time-utils.c#L193" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/NetworkManager/NetworkManager/blob/a7d8fe0ea5eb7be42a86527226ea54fd221fb1b4/shared/nm-glib-aux/nm-time-utils.c#L193</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23576">https://phabricator.kde.org/D23576</a></div></div><br /><div><strong>To: </strong>meven, jgrulich<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>