<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23470">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23470#inline-132593">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfiggroup.h:655</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KCONFIGCORE_DEPRECATED_EXPORT</span> <span style="color: #aa4000">static</span> <span class="n">QVariant</span> <span style="color: #004012">convertToQVariant</span><span class="p">(</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span> <span style="color: #aa2211">*</span><span class="n">pKey</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span style="color: #aa2211">&</span><span class="n">value</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVariant</span> <span style="color: #aa2211">&</span><span class="n">aDefault</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">convertToQVariant</span><span class="p">(</span><span class="n">pKey</span><span class="p">,</span> <span class="n">value</span><span class="p">,</span> <span class="n">aDefault</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">);</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">friend</span> <span class="n">class</span> <span class="n">KServicePrivate</span><span class="p">;</span> <span style="color: #74777d">// XXX yeah, ugly^5</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this must be kept non-inline, otherwise it's a symbol loss (and thus a BIC change)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R237 KConfig</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23470">https://phabricator.kde.org/D23470</a></div></div><br /><div><strong>To: </strong>apol, Frameworks<br /><strong>Cc: </strong>pino, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>