<table><tr><td style="">kossebau created this revision.<br />kossebau added reviewers: Plasma, hein, broulik.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />kossebau requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23418">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>get_fields() already cares for removing the quotes, the bits in get_str()<br />
are thus already operating on the final string, as well as it is broken<br />
in the calculation of the text length to copy.</p>
<p>Possibly were left-over from initial code drafts, as all this logic was<br />
already in the initial commit to kdelibs in <a href="https://phabricator.kde.org/R446:e5b75f8409e7fee6c798fac21a8a0e03be771b07" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">e5b75f8409e7</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Startup notification still works as before, quoted values like<br />
Description="Launching Dolphin"<br />
are still read in as before</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R278 KWindowSystem</div></div></div><br /><div><strong>BRANCH</strong><div><div>dropdeadcodeforremovingquotesfromstartupdatavalue</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23418">https://phabricator.kde.org/D23418</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kstartupinfo.cpp</div></div></div><br /><div><strong>To: </strong>kossebau, Plasma, hein, broulik<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>