<table><tr><td style="">yurchor added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23119">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23119#inline-132004">View Inline</a><span style="color: #4b4d51; font-weight: bold;">asemke</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kxmlgui_unittest.cpp:1089</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">there is no declension in Russian for the nominative case. The name of the month is январь and not января, but it is первого января (on January 1st) and not первого январь.</p>
<p style="padding: 0; margin: 8px;"><a href="https://doc.qt.io/qt-5/qlocale.html#monthName" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qlocale.html#monthName</a> - QLocale must return the name of the month, meaning the nominative case and not one of its declensions.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer (Ukrainian)</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/F7273188" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273188: cal.png</a></p>
<p style="padding: 0; margin: 8px;"><a href="https://bugs.kde.org/show_bug.cgi?id=256952" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=256952</a></p>
<p style="padding: 0; margin: 8px;">There are new specifiers for the primary and alternative month names in glibc but Qt does not implement them (must be something like "LLLL YYYY" instead of "MMMM YYYY" in formatting). Rafal Luzynski (the author of the glibc patch) in a private message (2018-01-25) promised me to send the patch for Qt but this has not happened yet.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23119">https://phabricator.kde.org/D23119</a></div></div><br /><div><strong>To: </strong>aacid<br /><strong>Cc: </strong>yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>