<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22946">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22946#inline-131600">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdbusservice.cpp:129</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">registered</span> <span style="color: #aa2211">=</span> <span class="n">bus</span><span style="color: #aa2211">-></span><span class="n">registerService</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">serviceName<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">QDBusConnectionInterface</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ServiceRegistered</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">registered</span> <span style="color: #aa2211">=</span> <span class="n">bus</span><span style="color: #aa2211">-></span><span class="n">registerService</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">serviceName</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                             <span class="p">,</span> <span class="p">(</span><span class="n">options</span> <span style="color: #aa2211">&</span> <span class="n">Replace</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span class="n">QDBusConnectionInterface</span><span style="color: #aa2211">::</span><span style="color: #a0a000">ReplaceExistingService</span> <span class="p">:</span> <span class="n">QDBusConnectionInterface</span><span style="color: #aa2211">::</span><span class="n">DontQueueService</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                             <span class="p">,</span> <span class="p">(</span><span class="n">options</span> <span style="color: #aa2211">&</span> <span class="n">Replace</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span class="n">QDBusConnectionInterface</span><span style="color: #aa2211">::</span><span style="color: #a0a000">AllowReplacement</span> <span class="p">:</span> <span class="n">QDBusConnectionInterface</span><span style="color: #aa2211">::</span><span class="n">DontAllowReplacement</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't like this part very much. It means we're registering the name whilst the former app is potentially still running.</p>

<p style="padding: 0; margin: 8px;">I would suggest rebasing on Harald's <a href="https://phabricator.kde.org/R271:5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6</a> change.</p>

<p style="padding: 0; margin: 8px;">It'll allow us to do this all in a race-free way.</p>

<p style="padding: 0; margin: 8px;">We can register the name org.kde.plasmashell in a queued manner<br />
then call quit on the current process, and then call waitForRegistration()</p>

<p style="padding: 0; margin: 8px;">and it'll be better than the current approach plasma does.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R271 KDBusAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22946">https://phabricator.kde.org/D22946</a></div></div><br /><div><strong>To: </strong>apol, Frameworks<br /><strong>Cc: </strong>davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>