<table><tr><td style="">trickyricky26 added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23116">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23116#511430" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23116#511430</a>, <a href="https://phabricator.kde.org/p/GB_2/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@GB_2</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors <tt style="background: #ebebeb; font-size: 13px;">ButtonFocus</tt> and <tt style="background: #ebebeb; font-size: 13px;">NegativeText</tt>: <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets</a></p></div>
</blockquote>
<p>I thought about that, too, and while the red used in the icon is exactly <tt style="background: #ebebeb; font-size: 13px;">NegativeText</tt>, the blue in the current icon is darker and has a less vibrant hue than <tt style="background: #ebebeb; font-size: 13px;">ButtonFocus</tt>, so I'm not quite comfortable with using that for the blue color. Do we have this darker blue as a CSS color that we can use in this way? I see this dark blue is also used in the <tt style="background: #ebebeb; font-size: 13px;">channelmixer</tt> icon, which has its colors hardcoded as well. I also don't think it would make sense to only use stylesheet colors for only one of these two colors.</p>
<p>Btw, in the relevant HIG page (<a href="https://hig.kde.org/style/icon.html#action-and-status-icons" class="remarkup-link" target="_blank" rel="noreferrer">https://hig.kde.org/style/icon.html#action-and-status-icons</a>) the color <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-ButtonFocus</tt> in the page you linked is called <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-Highlight</tt> and there are other anme differences, too. Is one of these inaccurate, or do they both work?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23116">https://phabricator.kde.org/D23116</a></div></div><br /><div><strong>To: </strong>trickyricky26, VDG, ngraham, ndavis<br /><strong>Cc: </strong>GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns<br /></div>