<table><tr><td style="">lisin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23036">View Revision</a></tr></table><br /><div><div><p>I didn't make a third copy of the positioning code, instead I put it all into a separate function.</p>
<p>For Kickoff you can test the changes like this:<br />
Place Kickoff in a vertical panel. Restart plasmashell. Open Kickoff.<br />
Before fix: first tab is placed out of bounds (y < 0).<br />
After fix: first tab is positioned correctly (y = 0).</p>
<p>As far as I see, other applets that use PlasmaComponents.TabBar (like Activity Bar, Grouping widget etc) weren't affected by the bug and they still work the same.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23036">https://phabricator.kde.org/D23036</a></div></div><br /><div><strong>To: </strong>lisin, Plasma, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>