<table><tr><td style="">ngraham accepted this revision.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23019">View Revision</a></tr></table><br /><div><div><p>Never mind, you did change it to <tt style="background: #ebebeb; font-size: 13px;">notification-inactive</tt> in the other patch. So this is good to go IMO.</p>
<p>As for landing it, we have two options to make sure that rolling release distro users don't see their notification icon change to the one with the red line through it:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Land this patch for 5.63 (the Frameworks release aligned with Plasma 5.17)</li>
<li class="remarkup-list-item">Change the inactive applet to use the <tt style="background: #ebebeb; font-size: 13px;">notification-inactive icon</tt> in another patch and land that on the stable branch, then land this</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23019">https://phabricator.kde.org/D23019</a></div></div><br /><div><strong>To: </strong>ndavis, VDG, Plasma, broulik, ngraham<br /><strong>Cc: </strong>ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns<br /></div>