<table><tr><td style="">ngraham accepted this revision.<br />ngraham added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22647">View Revision</a></tr></table><br /><div><div><p>Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet.</p>
<p>This will require documentation changes as well on <a href="https://hig.kde.org/style/icon.html" class="remarkup-link" target="_blank" rel="noreferrer">https://hig.kde.org/style/icon.html</a> and <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips</a></p>
<p>As for the change itself, this is what happens when using the light color scheme: <a href="https://phabricator.kde.org/F7076742" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7076742: Screenshot_20190722_080127.png</a></p>
<p>Seems like this change just shifts the problem from Breeze Dark to regular Breeze.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>BRANCH</strong><div><div>focus-color (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22647">https://phabricator.kde.org/D22647</a></div></div><br /><div><strong>To: </strong>ndavis, VDG, ngraham<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns<br /></div>