<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14631">View Revision</a></tr></table><br /><div><div><p>KIO::move (implemented by CopyJob) can move N files to a single destination directory, but they get the same name at that dest.<br />
KIO::moveAs (implemented by CopyJob too) can move/rename a single file to a specific filename at destination.</p>
<p>What you're suggesting is a new job that can move N files to a destination directory (to make this generic it doesn't have to be in-place renames, right?), but you're providing the filename at destination for each file, right?<br />
This sounds good to me. I could imagine this being handled by CopyJob too.<br />
The struct CopyInfo already stores source and destination URLs for every file, it's just that the destination URL is filled in CopyJobPrivate::slotResultStating by appending the filename to the dest dir, except in moveAs (m_asMethod==true) where the destination URL *is* the final filename.<br />
I could imagine a KIO::moveAs that takes two QList<QUrl> and then this information is fetched from there rather than using m_dest.<br />
In fact, if the existing moveAs() method is ported to call the two-QLists one, that will mean less special casing in the code (which wouldn't use m_dest anymore in slotResultStating, when m_asMethod).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14631">https://phabricator.kde.org/D14631</a></div></div><br /><div><strong>To: </strong>emateli, Frameworks, dfaure, mlaurent<br /><strong>Cc: </strong>anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns<br /></div>