<table><tr><td style="">arrowd added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22525">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22525#497556" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22525#497556</a>, <a href="https://phabricator.kde.org/p/cfeck/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cfeck</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Oh, if the latter syntax also works, then you are right.</p></div>
</blockquote>
<p>Not sure what you mean by "also works". Current code checks if the URL ends with <tt style="background: #ebebeb; font-size: 13px;">:x:y</tt> and turns it into <tt style="background: #ebebeb; font-size: 13px;">?line=x&column=y</tt>. This is used to open local text files at the given cursor position. However, for URL's like <tt style="background: #ebebeb; font-size: 13px;">http://localhost:3000</tt> it is invalid to perform such transformation. My patch checks URL scheme and applies the transformation only if it is <tt style="background: #ebebeb; font-size: 13px;">file://</tt>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R126 KDE CLI Utilities</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22525">https://phabricator.kde.org/D22525</a></div></div><br /><div><strong>To: </strong>arrowd<br /><strong>Cc: </strong>cfeck, plasma-devel, Frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>