<table><tr><td style="">meven commandeered this revision.<br />meven added a reviewer: ngraham.<br />meven added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7446">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7446#inline-124204">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesmodel.cpp:289</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KFilePlacesItem</span><span style="color: #aa2211">::</span><span class="n">createSystemBookmark</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bookmarkManager</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Today"</span><span class="p">),</span> <span class="n">I18N_NOOP2</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"</span><span class="p">,</span> <span style="color: #766510">"Today"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Created </span>Today"</span><span class="p">),</span> <span class="n">I18N_NOOP2</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"</span><span class="p">,</span> <span style="color: #766510">"Today"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QUrl</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"timeline:/today"</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"go-jump-today"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">timeline protocol works on modification date, we should change this to "Modified Today".<br />
It is a better feature anyway.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7446#inline-124205">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesmodel.cpp:292</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KFilePlacesItem</span><span style="color: #aa2211">::</span><span class="n">createSystemBookmark</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bookmarkManager</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Yesterday"</span><span class="p">),</span> <span class="n">I18N_NOOP2</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"</span><span class="p">,</span> <span style="color: #766510">"Yesterday"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Created </span>Yesterday"</span><span class="p">),</span> <span class="n">I18N_NOOP2</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"</span><span class="p">,</span> <span style="color: #766510">"Yesterday"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QUrl</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"timeline:/yesterday"</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view-calendar-day"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7446">https://phabricator.kde.org/D7446</a></div></div><br /><div><strong>To: </strong>meven, Dolphin, broulik, elvisangelaccio, markg, VDG, Frameworks, ngraham<br /><strong>Cc: </strong>meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, Konqueror, fprice, LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>